Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

avoid publishing new releases to deprecated bower#16013

Closed
graingert wants to merge 1 commit into
angular:masterfrom
graingert:avoid-publishing-bower
Closed

avoid publishing new releases to deprecated bower#16013
graingert wants to merge 1 commit into
angular:masterfrom
graingert:avoid-publishing-bower

Conversation

@graingert

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
N/A

What is the current behavior? (You can also link to an open issue here)
bower install angular

  • installs latest version of angularjs *

What is the new behavior (if this is a feature change)?
bower install angular
installs old version of angular

Does this PR introduce a breaking change?
yes, no new bower releases.

Please check if the PR fulfills these requirements

Other information:

@graingert

Copy link
Copy Markdown
Contributor Author

This will probably require some doc fixes for how people can transition to npm based angular, eg use /node_modules/ rather than /bower_components/

@graingert

Copy link
Copy Markdown
Contributor Author

currently this PR stops all new releases to bower, however it might be better to release 1.7 and above only on npm.

@gkalpak

gkalpak commented May 26, 2017

Copy link
Copy Markdown
Member

TBH, I don't see the benefit in doing so. Although not recommended for use in new projects, bower is still maintained and there are people using it. Given the next-to-zero overhead for us, I don't see why we should make the lives of people still using bower more difficult than they already are 😈

@graingert

graingert commented May 26, 2017

Copy link
Copy Markdown
Contributor Author

@gkalpak perhaps to start this off, I could make a PR that updates the tutorial to use plain old npm and move the bower option on the download page to the bottom and mark it as deprecated?

@gkalpak

gkalpak commented May 26, 2017

Copy link
Copy Markdown
Member

Well, that would be nice, but...the tutorial uses angular-seed as a starting point, so we need to update angular/angular-seed. And there are currently three PRs open for that (#385, #389, #390) 😳

We should get one of those in (probably #390) and then you could work on the tutorial 😁

@graingert

Copy link
Copy Markdown
Contributor Author

@gkalpak #390 is closed

@gkalpak

gkalpak commented May 26, 2017

Copy link
Copy Markdown
Member

Wrong link. Try again :)

@dcherman

dcherman commented Jun 5, 2017

Copy link
Copy Markdown
Contributor

Is there a cost to supporting bower? It seems needlessly breaking to stop publishing to it even if it is deprecated, especially since it's probably an automated process that is doing so.

@Narretz

Narretz commented Jun 5, 2017

Copy link
Copy Markdown
Contributor

I agree that stopping publishing to bower is a needless BC. I also agree that we can point out the deprecation where possible, but let's not track this in this PR.

@Narretz Narretz closed this Jun 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants